Add getAttachFiles() on PdfFileReader#56
Open
alexis-via wants to merge 1 commit intoclaird:masterfrom
Open
Conversation
Owner
|
Alexis, please accept my apology for the many months I've made you wait. Yes, please provide unit tests so we can commit this without further delay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a method to get all attachments from a PDF file.
I'm not an expert of PDF and this is my very first contribution to PyPDF. I'm working on the Factur-X / ZUGFeRD invoicing standards (PDF invoice with an embedded XML file) and I'm the author of the factur-x python lib (https://github.com/akretion/factur-x) that depend on PyPDF4. I think it would be great to have a method to get all attachments directly in the PyPDF lib.
If you think this PR has some chances to be accepted, I'll add unit tests for the getAttachFiles method.